The main reason for the naming has to do with the use of eggs, not the origin of the vanilla.
French vanilla ice cream uses egg yolks, which give it that yellow colouring instead of the whiteness of plain vanilla.
Egg yolk also give the cold favourite a smoother consistency and a richer taste.
Vanilla mystery solved!